Skip to content

REFACTOR: Reverting cfg to release 0.42.0 #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 78 commits into
base: main
Choose a base branch
from
Open

Conversation

svandenb-dev
Copy link
Collaborator

@svandenb-dev svandenb-dev commented Jun 13, 2025

This PR is reverting changes made on Configuration file after release 0.42.0 on grpc.

@hui-zhou-a please check PR's
#1264
#1260
which were committed post release 0.42.0

# Conflicts:
#	src/pyedb/grpc/database/layout/layout.py
# Conflicts:
#	src/pyedb/configuration/cfg_setup.py
@svandenb-dev svandenb-dev requested a review from hui-zhou-a June 13, 2025 14:07
@github-actions github-actions bot added the testing Anything related to testing label Jun 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 74.32735% with 229 lines in your changes missing coverage. Please review.

Project coverage is 76.62%. Comparing base (6580691) to head (a348d3f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1290      +/-   ##
==========================================
+ Coverage   75.79%   76.62%   +0.83%     
==========================================
  Files         163      163              
  Lines       23908    23099     -809     
==========================================
- Hits        18120    17699     -421     
+ Misses       5788     5400     -388     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This revert goes back to old code, which loose all fix after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants