Skip to content

Enhancement/choke/add material #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Mar 24, 2022
Merged

Conversation

jeremich41
Copy link
Contributor

Add new keys in the json file to select the material of the windings and the core. Add examples of a choke generation in HFSS and Maxwell3D.

@jeremich41 jeremich41 requested a review from maxcapodi78 March 24, 2022 10:22
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #989 (ebead3c) into main (ee6ff77) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main     #989   +/-   ##
=======================================
  Coverage   80.65%   80.66%           
=======================================
  Files         130      130           
  Lines       38458    38479   +21     
=======================================
+ Hits        31020    31038   +18     
- Misses       7438     7441    +3     

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 merged commit e0d66f2 into main Mar 24, 2022
@maxcapodi78 maxcapodi78 deleted the enhancement/Choke/AddMaterial branch March 24, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants