Split a polyline with a certain number of segment. #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #986 +/- ##
==========================================
+ Coverage 80.65% 80.67% +0.02%
==========================================
Files 130 130
Lines 38532 38571 +39
==========================================
+ Hits 31077 31118 +41
+ Misses 7455 7453 -2 |
This was
linked to
issues
Mar 24, 2022
This was
unlinked from
issues
Mar 24, 2022
maxcapodi78
requested changes
Mar 24, 2022
| @@ -486,3 +487,23 @@ def test_48_coordinate_systems_parametric(self): | |||
| cs4 = self.aedtapp.modeler.create_coordinate_system(name="CSP4", mode="zxz", phi=43, theta="126deg", psi=0) | |||
| tol = 1e-9 | |||
| assert sum([abs(x1 - x2) for (x1, x2) in zip(cs3.quaternion, cs4.quaternion)]) < tol | |||
|
|
|||
There was a problem hiding this comment.
All tests should have assert checks. Is there a way to also check if points have been created correctly?
There was a problem hiding this comment.
@maxcapodi78 Done. Thanks for the suggestion.
There was a problem hiding this comment.
@maxcapodi78 I used the get_oo_property_value() in the test assertion to make sure that the modeler operations were correct.
maxcapodi78
requested changes
Mar 26, 2022
maxcapodi78
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to split a polyline with a certain number of segment.
Fix #952 .
Fix #975 .