Fix get_component_placement_vector #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the usage of the merged component's center location in get_component_placement_vector for the offset calculation. Its return values are expected to be passed into place_in_layout_3d_placement, and this function applies the rotation around the origin.
Add a test case for placement of an offset component on the top layer.
ghost
requested review from
MaxJPRey
approved these changes
Mar 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #980 +/- ##
==========================================
+ Coverage 80.75% 80.78% +0.03%
==========================================
Files 128 128
Lines 38170 38237 +67
==========================================
+ Hits 30825 30891 +66
- Misses 7345 7346 +1 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the usage of the merged component's center location in
get_component_placement_vector for the offset calculation. Its return
values are expected to be passed into place_in_layout_3d_placement, and
this function applies the rotation around the origin.
This change corrects the offset calculation when the merged component
is not centered about the origin, for example when the component has
been cut out from a larger design.