Refactor optimetrics #974

maxcapodi78 · 2022-03-22T07:49:34Z

No description provided.

codecov · 2022-03-22T08:05:57Z

Codecov Report

Merging #974 (5aa1298) into main (fa4d455) will decrease coverage by 0.11%.
The diff coverage is 79.70%.

@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   80.75%   80.63%   -0.12%     
==========================================
  Files         128      130       +2     
  Lines       38170    38432     +262     
==========================================
+ Hits        30825    30991     +166     
- Misses       7345     7441      +96

Samuelopez-ansys · 2022-03-22T18:16:38Z

LGTM.

I have checked all the new methods and now is more aligned to the other pyAEDT classes. Nice improvement.

I have detected one issue, if we specify a different Setup than the default, this tab is not updated:

This is a problem because the parametric / optimization won't work. Maybe you know where to update this value in the code
@maxcapodi78
I have found the issue changing the unittest:

assert setup1.add_calculation(calculation="dB(S(1,1))", ranges={"Freq": "2.5GHz"}, solution="MySetupForSweep : LastAdaptive")

MaxJPRey · 2022-03-22T18:20:58Z

examples/00-EDB/00_EDB_Create_VIA.py

@@ -8,7 +8,7 @@
 ###############################################################################
 # Import the EDB Layout Object
 # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-# This example imports the EDB layout object and initializes it on version 2021.2.
+# This example imports the EDB layout object and initializes it on version 2022R2.


@maxcapodi78 Bellow we are mentioning 2022.1 in edb() initializer.

Suggested change

# This example imports the EDB layout object and initializes it on version 2022R2.

# This example imports the EDB layout object and initializes it on version 2022R1.

MaxJPRey · 2022-03-22T18:24:07Z

examples/00-EDB/01_edb_example.py

@@ -35,11 +35,11 @@
 # Launch EDB
 # ~~~~~~~~~~
 # This example launches the :class:`pyaedt.Edb` class.
-# This example uses EDB 2021.2 and uses SI units.
+# This example uses EDB 2022R2 and uses SI units.


Suggested change

# This example uses EDB 2022R2 and uses SI units.

# This example uses EDB 2022R1 and uses SI units.

MaxJPRey · 2022-03-22T18:24:43Z

examples/00-EDB/03_5G_antenna_example.py

@@ -8,7 +8,7 @@
 ###############################################################################
 # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 # This example imports the `Hfss3dlayout` object and initializes it on version
-# 2021.2.
+# 2022R2.


Suggested change

# 2022R2.

# 2022R1.

MaxJPRey · 2022-03-22T18:24:54Z

examples/00-EDB/02_edb_to_ipc2581.py

@@ -38,9 +38,9 @@
 # Launch EDB
 # ~~~~~~~~~~
 # This example launches the :class:`pyaedt.Edb` class.
-# This example uses EDB 2021.2 and uses SI units.
+# This example uses EDB 2022R2 and uses SI units.


Suggested change

# This example uses EDB 2022R2 and uses SI units.

# This example uses EDB 2022R1 and uses SI units.

MaxJPRey · 2022-03-22T18:25:16Z

examples/00-EDB/05_Plot_nets.py

@@ -31,9 +31,9 @@
 # Launch EDB
 # ~~~~~~~~~~
 # This example launches the :class:`pyaedt.Edb` class.
-# This example uses EDB 2021.2 and uses SI units.
+# This example uses EDB 2022R2 and uses SI units.


Suggested change

# This example uses EDB 2022R2 and uses SI units.

# This example uses EDB 2022R1 and uses SI units.

MaxJPRey · 2022-03-22T18:25:25Z

examples/01-Modeling-Setup/HFSS_CoordinateSystem.py

@@ -21,10 +21,10 @@
 ###############################################################################
 # Launch AEDT in Graphical Mode
 # -----------------------------
-# This example launches AEDT 2021.2 in graphical mode.
+# This example launches AEDT 2022R2 in graphical mode.


Suggested change

# This example launches AEDT 2022R2 in graphical mode.

# This example launches AEDT 2022R1 in graphical mode.

examples/02-HFSS/Advanced_Far_Field.py

MaxJPRey · 2022-03-23T09:09:01Z

pyaedt/application/Design.py

+        Returns
+        -------
+        object
+            Aedt Object if Any.


Suggested change

Aedt Object if Any.

Aedt Object if any.

Samuelopez-ansys

LGTM

maxcapodi78 added 6 commits March 21, 2022 10:07

first refactoring

f4e5bca

first refactoring

dca9ad4

Refactoring of DesignXPloration.py module

9ec8619

Fixed bug on solid_type

9b3fb48

Fixed bug on solid_type

3d077e9

Optimetrics refactoring

cde588b

maxcapodi78 added 5 commits March 22, 2022 10:37

Optimetrics refactoring

0f1fc22

Optimetrics refactoring

2a8d694

Optimetrics refactoring

e241973

Optimetrics refactoring

6c1be55

Optimetrics refactoring

03c3588

maxcapodi78 requested review from MaxJPRey, Alberto-DM and Samuelopez-ansys March 22, 2022 16:21

MaxJPRey reviewed Mar 22, 2022

View reviewed changes

examples/02-HFSS/Advanced_Far_Field.py Outdated Show resolved Hide resolved

MaxJPRey and others added 2 commits March 22, 2022 19:26

Update examples/02-HFSS/Advanced_Far_Field.py

04d7b5c

Fixed Optimetrics Multiple Setup assignment into the optimization

5bb4a6b

MaxJPRey reviewed Mar 23, 2022

View reviewed changes

MaxJPRey approved these changes Mar 23, 2022

View reviewed changes

maxcapodi78 added 2 commits March 23, 2022 10:30

Fixed Optimetrics Multiple Setup assignment into the optimization

1307fbe

Added Example for time animation

5aa1298

Samuelopez-ansys approved these changes Mar 23, 2022

View reviewed changes

maxcapodi78 merged commit d83e6d0 into main Mar 23, 2022

maxcapodi78 deleted the refactor_optimetrics branch March 23, 2022 13:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor optimetrics #974

Refactor optimetrics #974

Uh oh!

maxcapodi78 commented Mar 22, 2022

Uh oh!

codecov bot commented Mar 22, 2022 •

edited

Loading

Uh oh!

Samuelopez-ansys commented Mar 22, 2022

Uh oh!

MaxJPRey Mar 22, 2022

Uh oh!

MaxJPRey Mar 22, 2022

Uh oh!

MaxJPRey Mar 22, 2022

Uh oh!

MaxJPRey Mar 22, 2022

Uh oh!

MaxJPRey Mar 22, 2022

Uh oh!

MaxJPRey Mar 22, 2022

Uh oh!

Uh oh!

MaxJPRey Mar 23, 2022

Uh oh!

Samuelopez-ansys left a comment

Uh oh!

Uh oh!

	# This example imports the EDB layout object and initializes it on version 2022R2.
	# This example imports the EDB layout object and initializes it on version 2022R1.

	# This example uses EDB 2022R2 and uses SI units.
	# This example uses EDB 2022R1 and uses SI units.

	# This example launches AEDT 2022R2 in graphical mode.
	# This example launches AEDT 2022R1 in graphical mode.

Refactor optimetrics #974

Refactor optimetrics #974

Uh oh!

Conversation

maxcapodi78 commented Mar 22, 2022

Uh oh!

codecov bot commented Mar 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Samuelopez-ansys commented Mar 22, 2022

Uh oh!

MaxJPRey Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

MaxJPRey Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

MaxJPRey Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

MaxJPRey Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

MaxJPRey Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

MaxJPRey Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MaxJPRey Mar 23, 2022

Choose a reason for hiding this comment

Uh oh!

Samuelopez-ansys left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Mar 22, 2022 •

edited

Loading