Skip to content

Pre-commit applied to unit test files. #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 15, 2022
Merged

Conversation

MaxJPRey
Copy link
Collaborator

@MaxJPRey MaxJPRey commented Mar 14, 2022

The test files (except the example models) are now part of the pre-commit control.
Fix #948 .

@MaxJPRey MaxJPRey marked this pull request as draft March 14, 2022 14:05
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #953 (88f2fec) into main (7342fe0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
+ Coverage   80.42%   80.45%   +0.02%     
==========================================
  Files         128      128              
  Lines       37714    37777      +63     
==========================================
+ Hits        30332    30394      +62     
- Misses       7382     7383       +1     

@MaxJPRey MaxJPRey requested a review from maxcapodi78 March 14, 2022 17:11
@MaxJPRey MaxJPRey marked this pull request as ready for review March 14, 2022 17:11
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good cleaning of import calls too

@MaxJPRey MaxJPRey merged commit dbe38ad into main Mar 15, 2022
@MaxJPRey MaxJPRey deleted the maint/pre_commit_tests branch March 15, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit is not activated for the unit tests.
2 participants