Skip to content

Access edb_value from components using a method instead of a property. #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 16, 2022

Conversation

MaxJPRey
Copy link
Collaborator

Replace _edb_value protected property by a protected method _get_edb_value().
Codacy tool was raising mentioning that _edb_value was not callable. The property was returning a function object and using it to call an edb method.
Even though it was valid, it could be confusing when maintaining code.

Fix #911

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #938 (db2f706) into main (dbe38ad) will increase coverage by 0.07%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
+ Coverage   80.45%   80.53%   +0.07%     
==========================================
  Files         128      128              
  Lines       37777    37855      +78     
==========================================
+ Hits        30394    30486      +92     
+ Misses       7383     7369      -14     

@maxcapodi78
Copy link
Collaborator

@MaxJPRey I like the approach but we should standardize in edb_core classes. can you replace it in any classes in edb_core the property with the method?

@MaxJPRey
Copy link
Collaborator Author

@MaxJPRey I like the approach but we should standardize in edb_core classes. can you replace it in any classes in edb_core the property with the method?

Sure @maxcapodi78 I will do it.

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxJPRey MaxJPRey merged commit b3f7cce into main Mar 16, 2022
@MaxJPRey MaxJPRey deleted the fix/issue_911 branch March 16, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

self._edb_value is not callable in component module
2 participants