-
Notifications
You must be signed in to change notification settings - Fork 162
Access edb_value from components using a method instead of a property. #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #938 +/- ##
==========================================
+ Coverage 80.45% 80.53% +0.07%
==========================================
Files 128 128
Lines 37777 37855 +78
==========================================
+ Hits 30394 30486 +92
+ Misses 7383 7369 -14 |
@MaxJPRey I like the approach but we should standardize in edb_core classes. can you replace it in any classes in edb_core the property with the method? |
Sure @maxcapodi78 I will do it. |
…odule of edb_core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replace
_edb_value
protected property by a protected method_get_edb_value()
.Codacy tool was raising mentioning that
_edb_value
was not callable. The property was returning a function object and using it to call an edb method.Even though it was valid, it could be confusing when maintaining code.
Fix #911