Skip to content

Fix Voids replacement after cutout is performed. #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Conversation

maxcapodi78
Copy link
Collaborator

@maxcapodi78 maxcapodi78 commented Mar 8, 2022

Now also polygon voids intersecting cutout region are added.

@maxcapodi78 maxcapodi78 requested a review from Alberto-DM March 8, 2022 09:36
Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #926 (8ed71c0) into main (44f828a) will increase coverage by 0.01%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
+ Coverage   80.10%   80.12%   +0.01%     
==========================================
  Files         128      128              
  Lines       37354    37364      +10     
==========================================
+ Hits        29924    29938      +14     
+ Misses       7430     7426       -4     

@MaxJPRey MaxJPRey changed the title Fix Voids replacement after cutout is perfromed. Now also polygon voi… Fix Voids replacement after cutout is performed. Now also polygon voi… Mar 8, 2022
@MaxJPRey MaxJPRey changed the title Fix Voids replacement after cutout is performed. Now also polygon voi… Fix Voids replacement after cutout is performed. Mar 8, 2022
@maxcapodi78 maxcapodi78 merged commit e524d08 into main Mar 8, 2022
@maxcapodi78 maxcapodi78 deleted the Fix_cutout_voids branch March 8, 2022 11:24
@maxcapodi78 maxcapodi78 restored the Fix_cutout_voids branch March 9, 2022 11:50
@maxcapodi78 maxcapodi78 deleted the Fix_cutout_voids branch March 9, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants