Skip to content

refactored parse_dim_arg #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2022
Merged

refactored parse_dim_arg #923

merged 4 commits into from
Mar 7, 2022

Conversation

maxcapodi78
Copy link
Collaborator

#921 Fix

@maxcapodi78 maxcapodi78 requested a review from Alberto-DM March 7, 2022 15:50
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #923 (0e96d52) into main (6b2611b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0e96d52 differs from pull request most recent head 7e8a592. Consider uploading reports for the commit 7e8a592 to get more accurate results

@@           Coverage Diff           @@
##             main     #923   +/-   ##
=======================================
  Coverage   80.10%   80.11%           
=======================================
  Files         128      128           
  Lines       37348    37354    +6     
=======================================
+ Hits        29918    29925    +7     
+ Misses       7430     7429    -1     

Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@maxcapodi78 maxcapodi78 merged commit 44f828a into main Mar 7, 2022
@maxcapodi78 maxcapodi78 deleted the FixIssue921 branch March 7, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants