Refactored Unit Test Startup and Teardown #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2022 10:41
Codecov Report
@@ Coverage Diff @@
## main #916 +/- ##
==========================================
- Coverage 80.15% 80.11% -0.05%
==========================================
Files 128 128
Lines 37242 37244 +2
==========================================
- Hits 29851 29837 -14
- Misses 7391 7407 +16 |
Alberto-DM
reviewed
Mar 4, 2022
_unittest/conftest.py
Outdated
| def my_teardown(self, close_desktop=False): | ||
| if close_desktop and not is_ironpython: | ||
| d = Desktop(desktop_version, non_graphical, False) | ||
| d.release_desktop() |
There was a problem hiding this comment.
I would add also del self.aedtapps and del self.edbapps.
_unittest/conftest.py
Outdated
|
|
||
| def add_app(self, project_name=None, design_name=None, solution_type=None, application=None): | ||
| if "oDesktop" not in dir(sys.modules["__main__"]): | ||
| if self.aedtapps: | ||
| self.aedtapps[0].release_desktop() |
There was a problem hiding this comment.
Is this a safety mechanism?
I don't get when it will execute this release_desktop
There was a problem hiding this comment.
you are right. it should be in the teardown method.
MaxJPRey
reviewed
Mar 4, 2022
_unittest/conftest.py
Outdated
Comment on lines
185
to
187
| # desktop = Desktop(desktop_version, non_graphical, new_thread) | ||
| # desktop.disable_autosave() | ||
| # yield desktop |
There was a problem hiding this comment.
Suggested change
| # desktop = Desktop(desktop_version, non_graphical, new_thread) | |
| # desktop.disable_autosave() | |
| # yield desktop |
MaxJPRey
reviewed
Mar 4, 2022
_unittest/conftest.py
Outdated
Comment on lines
189
to
190
| # If new_thread is set to false by a local_config, then don't close the desktop. | ||
| # Intended for local debugging purposes only |
There was a problem hiding this comment.
Suggested change
| # If new_thread is set to false by a local_config, then don't close the desktop. | |
| # Intended for local debugging purposes only |
MaxJPRey
reviewed
Mar 4, 2022
_unittest/conftest.py
Outdated
Comment on lines
191
to
192
| # if new_thread or os.name == "posix": | ||
| # desktop.close_desktop() |
There was a problem hiding this comment.
@maxcapodi78 It is not required anymore to have this new-thread for local debugging session?
Suggested change
| # if new_thread or os.name == "posix": | |
| # desktop.close_desktop() |
MaxJPRey
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now EDB tests and all tests that doesn't need AEDT runs before the others and outside the desktop