Skip to content

Add pre-commit checks. #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Mar 4, 2022
Merged

Add pre-commit checks. #906

merged 42 commits into from
Mar 4, 2022

Conversation

MaxJPRey
Copy link
Collaborator

@MaxJPRey MaxJPRey commented Mar 2, 2022

Add the pre-commit checks to fix style issues before to push any changes.

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #906 (7b1a649) into main (9c37254) will increase coverage by 0.03%.
The diff coverage is 95.30%.

@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
+ Coverage   80.12%   80.15%   +0.03%     
==========================================
  Files         128      128              
  Lines       36987    37242     +255     
==========================================
+ Hits        29634    29851     +217     
- Misses       7353     7391      +38     

Copy link
Contributor

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Prior to merge, verify @maxcapodi78 approves and agrees with pre-commit process. It should be much less annoying than using other tools in isolation.

@MaxJPRey MaxJPRey merged commit 7202b92 into main Mar 4, 2022
@MaxJPRey MaxJPRey deleted the maint/pre_commit branch March 4, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants