Improved rotation vector computation #903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Mar 1, 2022
Alberto-DM
reviewed
Mar 1, 2022
Codecov Report
@@ Coverage Diff @@
## main #903 +/- ##
==========================================
+ Coverage 79.66% 79.81% +0.14%
==========================================
Files 128 128
Lines 36462 36524 +62
==========================================
+ Hits 29049 29152 +103
+ Misses 7413 7372 -41 |
MaxJPRey
reviewed
Mar 1, 2022
| if hosting_component_pin2: | ||
| h_pin2 = self._get_edb_pin_from_pin_name(hosting_component, hosting_component_pin2) | ||
| h_pin2_pos = self.get_pin_position(h_pin2) | ||
| h_pin2_pos_3d = [h_pin2_pos[0], h_pin2_pos[1], 0] | ||
| # |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved method get_component_placement_vector that is useful in case of automatic placement of aedb layout.
Minor fixes to be compatible with AEDT 2022R1