improved remove_vertex method #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #861 +/- ##
==========================================
+ Coverage 78.75% 78.80% +0.05%
==========================================
Files 128 128
Lines 35281 35333 +52
==========================================
+ Hits 27785 27844 +59
+ Misses 7496 7489 -7 |
MaxJPRey
reviewed
Feb 16, 2022
MaxJPRey
reviewed
Feb 16, 2022
| angle : float, optional | ||
| Angle of rotation. The units, defined by ``unit``, can be either | ||
| degrees or radians. The default is ``90.0``. | ||
| unit : text, optional |
There was a problem hiding this comment.
Suggested change
| unit : text, optional | |
| unit : str, optional |
MaxJPRey
reviewed
Feb 16, 2022
Comment on lines
+1717
to
+1718
| objid : list, Position object | ||
| List of object IDs. |
There was a problem hiding this comment.
@maxcapodi78 I don't think it is used anymore. It seems that you use self.id now. But just to be sure.
Suggested change
| objid : list, Position object | |
| List of object IDs. |
MaxJPRey
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.