Find the largest area rectangle in a polygon. #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made vector function compatible with 2D vectors.
Codecov Report
@@ Coverage Diff @@
## main #854 +/- ##
==========================================
+ Coverage 79.81% 80.21% +0.40%
==========================================
Files 128 128
Lines 36493 36949 +456
==========================================
+ Hits 29126 29640 +514
+ Misses 7367 7309 -58 |
increased unit tests.
get_mid_point works for any vector length.
Co-authored-by: Maxime Rey <[email protected]>
… into Enhancement/configs
# Conflicts: # pyaedt/edb.py
…ctangle_inside_polygon
# Conflicts: # _unittest/conftest.py # pyaedt/generic/general_methods.py
akaszynski
reviewed
Feb 21, 2022
akaszynski
reviewed
Feb 21, 2022
akaszynski
reviewed
Feb 21, 2022
akaszynski
reviewed
Feb 21, 2022
akaszynski
reviewed
Feb 21, 2022
MaxJPRey
reviewed
Feb 22, 2022
MaxJPRey
reviewed
Feb 22, 2022
MaxJPRey
reviewed
Feb 22, 2022
MaxJPRey
reviewed
Feb 22, 2022
MaxJPRey
reviewed
Feb 22, 2022
MaxJPRey
reviewed
Feb 22, 2022
MaxJPRey
reviewed
Feb 22, 2022
MaxJPRey
reviewed
Feb 22, 2022
MaxJPRey
reviewed
Feb 22, 2022
MaxJPRey
reviewed
Feb 22, 2022
MaxJPRey
reviewed
Feb 22, 2022
Co-authored-by: Maxime Rey <[email protected]>
maxcapodi78
reviewed
Feb 23, 2022
# Conflicts: # _unittest/test_00_EDB.py # _unittest/test_04_GeometryOperators.py # pyaedt/modeler/GeometryOperators.py
# Conflicts: # _unittest/test_00_EDB.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find the largest area rectangle in a polygon with arbitrary orientation.
Added new functions to GeometryOperators.
Made vector function compatible with 2D vectors.