Skip to content

Update an existing user-defined primitive (UDP). #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 16, 2022

Conversation

MaxJPRey
Copy link
Collaborator

@MaxJPRey MaxJPRey commented Feb 14, 2022

It is now possible to update an existing geometry object that was originally created using UDP.
Add unit tests for the UDP updates.
Fix #847 .

@MaxJPRey MaxJPRey changed the title Update an existing UDP Update an existing user-defined primitive (UDP). Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #850 (231735e) into main (8c69d2a) will increase coverage by 0.00%.
The diff coverage is 96.00%.

@@           Coverage Diff           @@
##             main     #850   +/-   ##
=======================================
  Coverage   78.12%   78.13%           
=======================================
  Files         128      128           
  Lines       35350    35375   +25     
=======================================
+ Hits        27617    27640   +23     
- Misses       7733     7735    +2     

@MaxJPRey MaxJPRey requested a review from maxcapodi78 February 14, 2022 08:56
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxJPRey MaxJPRey merged commit 39d8233 into main Feb 16, 2022
@MaxJPRey MaxJPRey deleted the feat/change_udp_params branch February 16, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of UDPs
2 participants