Skip to content

Plot screenshots using "s" key #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 9, 2022
Merged

Plot screenshots using "s" key #844

merged 9 commits into from
Feb 9, 2022

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion on using os.path to get the extension.
I am approving it, after the change you can merge it.

def s_callback():
"""save screenshots"""
exp = os.path.join(path_image,
"{}{}.{}".format(root_name, datetime.now().strftime("%Y_%M_%d_%H-%M-%S"), format))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"{}{}.{}".format(root_name, datetime.now().strftime("%Y_%M_%d_%H-%M-%S"), format))
root_name + datetime.now().strftime("%Y_%M_%d_%H-%M-%S") + format)

if you use os.path.splitext

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #844 (fcdd961) into main (97f8b40) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
+ Coverage   77.81%   77.96%   +0.14%     
==========================================
  Files         128      128              
  Lines       35198    35210      +12     
==========================================
+ Hits        27391    27450      +59     
+ Misses       7807     7760      -47     

@maxcapodi78 maxcapodi78 merged commit 8f452e1 into main Feb 9, 2022
@maxcapodi78 maxcapodi78 deleted the Enhancement/Plot branch February 9, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants