-
Notifications
You must be signed in to change notification settings - Fork 161
Plot screenshots using "s" key #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion on using os.path to get the extension.
I am approving it, after the change you can merge it.
pyaedt/generic/plot.py
Outdated
def s_callback(): | ||
"""save screenshots""" | ||
exp = os.path.join(path_image, | ||
"{}{}.{}".format(root_name, datetime.now().strftime("%Y_%M_%d_%H-%M-%S"), format)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"{}{}.{}".format(root_name, datetime.now().strftime("%Y_%M_%d_%H-%M-%S"), format)) | |
root_name + datetime.now().strftime("%Y_%M_%d_%H-%M-%S") + format) |
if you use os.path.splitext
Codecov Report
@@ Coverage Diff @@
## main #844 +/- ##
==========================================
+ Coverage 77.81% 77.96% +0.14%
==========================================
Files 128 128
Lines 35198 35210 +12
==========================================
+ Hits 27391 27450 +59
+ Misses 7807 7760 -47 |
Co-authored-by: Alberto-DM <[email protected]>
Co-authored-by: Alberto-DM <[email protected]>
No description provided.