Removed modeler.primitives from unit tests and examples as it is deprecated. #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecated and now any methods from primitives can be called directly from modeler eg. modeler.primitives.create_box becomes modeler.create_box
Codecov Report
@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 77.38% 77.55% +0.17%
==========================================
Files 128 128
Lines 34840 35178 +338
==========================================
+ Hits 26961 27284 +323
- Misses 7879 7894 +15 |
Alberto-DM
approved these changes
Feb 8, 2022
| @@ -124,14 +124,14 @@ def test_create_regular_polygon(self): | |||
|
|
|||
| @pytest.mark.skipif(config["build_machine"] or is_ironpython, reason="Not running in ironpython") | |||
| def test_plot(self): | |||
| self.aedtapp.modeler.primitives.create_regular_polygon([0, 0, 0], [0, 2, 0]) | |||
| self.aedtapp.modeler.primitives.create_regular_polygon( | |||
| self.aedtapp.modeler.create_regular_polygon([0, 0, 0], [0, 2, 0]) | |||
There was a problem hiding this comment.
There are some lines, like this one, without an assert. Any reason why there is no assert?
They are notified by codecov.
Maybe we can exclude all unit tests from code coverage.
There was a problem hiding this comment.
because those one are needed to the test assertion which is a couple of lines below
MaxJPRey
changed the title
MaxJPRey
approved these changes
Feb 8, 2022
|
LGTM. Well Done @maxcapodi78 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ecated and now any methods from primitives can be called directly from modeler
eg. modeler.primitives.create_box becomes modeler.create_box