Added method to create dynamic link subcircuit valid for Q3d, Q2d and HFSS #832
Conversation
Codecov Report
@@ Coverage Diff @@
## main #832 +/- ##
==========================================
+ Coverage 77.10% 77.32% +0.21%
==========================================
Files 127 128 +1
Lines 34392 34646 +254
==========================================
+ Hits 26518 26790 +272
+ Misses 7874 7856 -18 |
| model_type=pyaedt_app.design_type, | ||
| variables=variables, | ||
| extrusion_length_q2d=extrusion_length, | ||
| matrix=matrix, |
There was a problem hiding this comment.
@maxcapodi78 I might be wrong but is seems that matrix will always be None, as it is set to None line 1210 and never changed after that. Is it expected?
So maybe we could get rid of the line 1210.
There was a problem hiding this comment.
@maxcapodi78 , I agree with @MaxJPRey, matrix should be obtained before the call of _add_subcircuit_link(...), I think with the new PR (#834) this should be accessible
There was a problem hiding this comment.
you are both right. but the matrix is gonna be filled with my other PR. I've prepared the method with variable and then I'll use such variable once Matrix is there
Co-authored-by: Maxime Rey <[email protected]>
…to Enhancement/dynamic_link_q3d
No description provided.