Skip to content

Add the clear option when creating a new HFSS sweep subrange. #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 4, 2022

Conversation

MaxJPRey
Copy link
Collaborator

@MaxJPRey MaxJPRey commented Feb 4, 2022

From now on, add_subrange() has a new clear argument.
It is possible to reset/delete all the existing and default sweeps of the setup.
Some new unit tests were added for the add_subrange().
Fix #743 .

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #819 (232b002) into main (23afee0) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
+ Coverage   76.84%   77.08%   +0.24%     
==========================================
  Files         127      127              
  Lines       34091    34355     +264     
==========================================
+ Hits        26196    26483     +287     
+ Misses       7895     7872      -23     

@MaxJPRey MaxJPRey requested a review from maxcapodi78 February 4, 2022 13:06
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxJPRey MaxJPRey merged commit 21d16e5 into main Feb 4, 2022
@MaxJPRey MaxJPRey deleted the fix/issue_743 branch February 4, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default item exist in sweepHFSS when setup.add_sweep()
2 participants