Skip to content

Choke Generation #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 127 commits into from
Feb 27, 2022
Merged

Choke Generation #812

merged 127 commits into from
Feb 27, 2022

Conversation

jeremich41
Copy link
Contributor

@jeremich41 jeremich41 commented Feb 3, 2022

Adding:

  • Two methods which allow to generate different kinds of chokes (doughnut-shaped coil) from a specific Json file.
  • Four geometry operators methods which allow : convert to degrees or to radians by default or by excess.
  • Mirror method for Object3d.

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #812 (91e68a2) into main (c37730f) will increase coverage by 0.19%.
The diff coverage is 90.95%.

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
+ Coverage   79.47%   79.66%   +0.19%     
==========================================
  Files         128      128              
  Lines       35889    36462     +573     
==========================================
+ Hits        28521    29049     +528     
- Misses       7368     7413      +45     

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 merged commit d31ebac into main Feb 27, 2022
@maxcapodi78 maxcapodi78 deleted the enhancement/test branch February 27, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants