Skip to content

Assign correct CS to the Antenna Inserted #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

Samuelopez-ansys
Copy link
Member

Bug fixed assigning the specific Target CS. It was not specified and it didn't work as expected, the original CS was used instead of the new one created in the previous line.

Tested for both JSON files (1Tx_1Rx and 1Tx_4Rx)

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #809 (ca5ae0c) into main (785163b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   76.84%   76.84%           
=======================================
  Files         127      127           
  Lines       34091    34091           
=======================================
  Hits        26196    26196           
  Misses       7895     7895           

@Samuelopez-ansys Samuelopez-ansys merged commit 23afee0 into ansys:main Feb 2, 2022
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue_808 branch February 2, 2022 15:13
@Samuelopez-ansys Samuelopez-ansys linked an issue Feb 3, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CS in SBR+ Antenna is not assigned correctly
2 participants