Skip to content

Fix, port renorm option is respected also in Driven Terminal #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Fix, port renorm option is respected also in Driven Terminal #760

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6547a2d
add renorm option to _create_port_terminal
Alberto-DM Jan 24, 2022
54ef3ec
added unit test for renorm option
Alberto-DM Jan 24, 2022
78893d3
style changes
Alberto-DM Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions pyaedt/hfss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ def _create_lumped_driven(self, objectname, int_line_start, int_line_stop, imped
return self._create_boundary(portname, props, "LumpedPort")

@aedt_exception_handler
def _create_port_terminal(self, objectname, int_line_stop, portname, iswaveport=False):
def _create_port_terminal(self, objectname, int_line_stop, portname, renorm=True, iswaveport=False):
ref_conductors = self.modeler.convert_to_selections(int_line_stop, True)
props = OrderedDict({})
props["Faces"] = int(objectname)
Expand Down Expand Up @@ -338,7 +338,7 @@ def _create_port_terminal(self, objectname, int_line_stop, portname, iswaveport=
props["DoDeembed"] = True
if iswaveport:
props["DeembedDist"] = "0mm"
props["RenormalizeAllTerminals"] = True
props["RenormalizeAllTerminals"] = renorm
props["ShowReporterFilter"] = False
props["UseAnalyticAlignment"] = False
boundary.props = props
Expand Down Expand Up @@ -1596,7 +1596,7 @@ def create_lumped_port_between_objects(
return self._create_lumped_driven(sheet_name, point0, point1, impedance, portname, renorm, deemb)
else:
faces = self.modeler.primitives.get_object_faces(sheet_name)
return self._create_port_terminal(faces[0], endobject, portname, iswaveport=False)
return self._create_port_terminal(faces[0], endobject, portname, renorm=renorm, iswaveport=False)
return False

@aedt_exception_handler
Expand Down Expand Up @@ -2051,7 +2051,7 @@ def create_wave_port_between_objects(
)
else:
faces = self.modeler.primitives.get_object_faces(sheet_name)
return self._create_port_terminal(faces[0], endobject, portname, iswaveport=True)
return self._create_port_terminal(faces[0], endobject, portname, renorm=renorm, iswaveport=True)
return False

@aedt_exception_handler
Expand Down Expand Up @@ -2480,7 +2480,7 @@ def create_wave_port_microstrip_between_objects(
)
else:
faces = self.modeler.primitives.get_object_faces(sheet_name)
return self._create_port_terminal(faces[0], endobject, portname, iswaveport=True)
return self._create_port_terminal(faces[0], endobject, portname, renorm=renorm, iswaveport=True)
return False

@aedt_exception_handler
Expand Down Expand Up @@ -3069,7 +3069,7 @@ def create_wave_port_from_sheet(
elif portname in self.modeler.get_excitations_name():
portname = generate_unique_name(portname)
if terminal_references:
return self._create_port_terminal(faces, terminal_references, portname, iswaveport=True)
return self._create_port_terminal(faces, terminal_references, portname, renorm=renorm, iswaveport=True)
else:
self.logger.error("Reference Conductors are missed.")
return False
Expand Down Expand Up @@ -3148,7 +3148,9 @@ def create_lumped_port_to_sheet(
if not faces:
self.logger.error("Wrong Input object. it has to be a face id or a sheet.")
return False
port = self._create_port_terminal(faces, reference_object_list, portname, iswaveport=False)
port = self._create_port_terminal(
faces, reference_object_list, portname, renorm=renorm, iswaveport=False
)

return port
return False
Expand All @@ -3166,7 +3168,7 @@ def assig_voltage_source_to_sheet(self, sheet_name, axisdir=0, sourcename=None):
"`assig_voltage_source_to_sheet` is deprecated. Use `assign_voltage_source_to_sheet` instead.",
DeprecationWarning,
)
self.assign_voltage_source_to_sheet(sheet_name, axisdir=0, sourcename=None)
self.assign_voltage_source_to_sheet(sheet_name, axisdir, sourcename)

@aedt_exception_handler
def assign_voltage_source_to_sheet(self, sheet_name, axisdir=0, sourcename=None):
Expand Down
4 changes: 2 additions & 2 deletions pyaedt/modeler/Modeler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3459,8 +3459,8 @@ def get_bounding_dimension(self):
Returns
-------
list
List of six float values representing the bounding box
in the form ``[min_x, min_y, min_z, max_x, max_y, max_z]``.
List of three float values representing the bounding box dimensions
in the form ``[dim_x, dim_y, dim_z]``.

References
----------
Expand Down