Feat/add twinbuilder example #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

maxcapodi78 merged 11 commits into main from feat/add-twinbuilder-example

Jan 21, 2022

Contributor

SushobhitGupt commented Jan 21, 2022 •

edited

Loading

Add a new RC Circuit example for Twin Builder
Add a new Voltage Source Component for Twin Builder

SushobhitGupt added 4 commits

January 20, 2022 19:37


          - Add new Voltage Source Component

560306f

- Ensure capacitor has initial conditions set


          Add a Twin Builder Example to create a RC Circuit on the fly and obse…

24d2022

…rve the results using matplotlib


          fix up flake8 issues

8c1bf5b


          fixup black styles

648cf63

SushobhitGupt requested review from maxcapodi78 and MaxJPRey

January 21, 2022 01:03

MaxJPRey reviewed

View reviewed changes

pyaedt/modeler/PrimitivesSimplorer.py Outdated Show resolved Hide resolved

MaxJPRey reviewed

View reviewed changes

pyaedt/modeler/PrimitivesSimplorer.py Outdated Show resolved Hide resolved

MaxJPRey reviewed

View reviewed changes

pyaedt/modeler/PrimitivesSimplorer.py Outdated Show resolved Hide resolved

MaxJPRey reviewed

View reviewed changes

pyaedt/modeler/PrimitivesSimplorer.py Outdated Show resolved Hide resolved

MaxJPRey reviewed

View reviewed changes

examples/07-TwinBuilder/01-RC_Circuit_Example.py Outdated Show resolved Hide resolved

MaxJPRey reviewed

View reviewed changes

examples/07-TwinBuilder/01-RC_Circuit_Example.py Outdated Show resolved Hide resolved

MaxJPRey approved these changes

View reviewed changes

Collaborator

MaxJPRey commented Jan 21, 2022

@sushobhit-gupt
In each folder containing an example we have a Readme.txt file presenting the purpose of those examples. Maybe you can add it.
Otherwise, it looks good to me and very nice example.

Collaborator

maxcapodi78 commented Jan 21, 2022

@sushobhit-gupt @MaxJPRey I agree, we need the readme.txt in the folder. This will be used in the header of the examples in online documentation. You can take as reference one of the other readme files.

maxcapodi78 requested changes

View reviewed changes

Collaborator

maxcapodi78 left a comment

Please add the Readme.txt. Then it looks great to me.

SushobhitGupt and others added 7 commits

January 21, 2022 08:54


          Update examples/07-TwinBuilder/01-RC_Circuit_Example.py

Co-authored-by: Maxime Rey <[email protected]>


          Update pyaedt/modeler/PrimitivesSimplorer.py

b13d7c2

Co-authored-by: Maxime Rey <[email protected]>


          Update pyaedt/modeler/PrimitivesSimplorer.py

da216ed

Co-authored-by: Maxime Rey <[email protected]>


          Update pyaedt/modeler/PrimitivesSimplorer.py

b9de683

Co-authored-by: Maxime Rey <[email protected]>


          Update examples/07-TwinBuilder/01-RC_Circuit_Example.py

6c5bbcc

Co-authored-by: Maxime Rey <[email protected]>


          Update pyaedt/modeler/PrimitivesSimplorer.py

8b9e631

Co-authored-by: Maxime Rey <[email protected]>


          Add Example Readme.txt

8b46c1b

Contributor Author

SushobhitGupt commented Jan 21, 2022 •

edited

Loading

Please add the Readme.txt. Then it looks great to me.

@maxcapodi78 @MaxJPRey I have added the new readme for Twin Builder and merged the changes from @MaxJPRey .
Please take a look when you get a chance.

maxcapodi78 approved these changes

View reviewed changes

maxcapodi78 merged commit fbb2eea into main

maxcapodi78 deleted the feat/add-twinbuilder-example branch

January 21, 2022 16:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet