modeler move() method #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxJPRey
reviewed
Jan 20, 2022
pyaedt/modeler/Modeler.py
Outdated
| ---------- | ||
| objid : str, int, or Object3d | ||
| Name or ID of the object. | ||
| vector : float |
There was a problem hiding this comment.
Suggested change
| vector : float | |
| vector : list |
MaxJPRey
reviewed
Jan 20, 2022
| ``True`` when successful, ``False`` when failed. | ||
| """ | ||
| selections = self.convert_to_selections(objid) | ||
| Xvec, Yvec, Zvec = self.primitives._pos_with_arg(vector) |
There was a problem hiding this comment.
Suggested change
| Xvec, Yvec, Zvec = self.primitives._pos_with_arg(vector) | |
| x_vec, y_vec, z_vec = self.primitives._pos_with_arg(vector) |
MaxJPRey
reviewed
Jan 20, 2022
Comment on lines
+1809
to
+1811
| vArg2.append("TranslateVectorX:="), vArg2.append(Xvec) | ||
| vArg2.append("TranslateVectorY:="), vArg2.append(Yvec) | ||
| vArg2.append("TranslateVectorZ:="), vArg2.append(Zvec) |
There was a problem hiding this comment.
Suggested change
| vArg2.append("TranslateVectorX:="), vArg2.append(Xvec) | |
| vArg2.append("TranslateVectorY:="), vArg2.append(Yvec) | |
| vArg2.append("TranslateVectorZ:="), vArg2.append(Zvec) | |
| vArg2.append("TranslateVectorX:="), vArg2.append(x_vec) | |
| vArg2.append("TranslateVectorY:="), vArg2.append(y_vec) | |
| vArg2.append("TranslateVectorZ:="), vArg2.append(z_vec) |
MaxJPRey
reviewed
Jan 20, 2022
Comment on lines
+1753
to
1754
| position : int or float | ||
| List of the ``[x, y, z]`` coordinates or the |
There was a problem hiding this comment.
Suggested change
| position : int or float | |
| List of the ``[x, y, z]`` coordinates or the | |
| position : list | |
| List of int or float of the ``[x, y, z]`` coordinates or the |
MaxJPRey
reviewed
Jan 20, 2022
| @@ -1784,6 +1784,34 @@ def mirror(self, objid, position, vector): | |||
|
|
|||
| return True | |||
|
|
|||
| @aedt_exception_handler | |||
| def move(self, objid, vector): | |||
There was a problem hiding this comment.
Suggested change
| def move(self, objid, vector): | |
| def move(self, object_id, vector): |
MaxJPRey
reviewed
Jan 20, 2022
pyaedt/modeler/Modeler.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| objid : str, int, or Object3d |
There was a problem hiding this comment.
Suggested change
| objid : str, int, or Object3d | |
| object_id : str, int, or Object3d |
MaxJPRey
reviewed
Jan 20, 2022
pyaedt/modeler/Modeler.py
Outdated
| bool | ||
| ``True`` when successful, ``False`` when failed. | ||
| """ | ||
| selections = self.convert_to_selections(objid) |
There was a problem hiding this comment.
Suggested change
| selections = self.convert_to_selections(objid) | |
| selections = self.convert_to_selections(object_id) |
MaxJPRey
approved these changes
Jan 20, 2022
|
@ring630 I just proposed some minor modifications about the variable's names to try to follow the 'snake_case' convention. |
|
@MaxJPRey Thanks for the view. The method move was already there but it is called translate. I will copy the content from translate and add a deprecation warning in translate method. |
|
@ring630, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.