Spiral Ports #745
Merged
Spiral Ports #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pyaedt/hfss.py
- update requirements
…iscrepancies between the file and the actual project open in UI
…iscrepancies between the file and the actual project open in UI
MaxJPRey
reviewed
Jan 20, 2022
MaxJPRey
reviewed
Jan 20, 2022
Maxime suggestions Co-authored-by: Maxime Rey <[email protected]>
MaxJPRey
reviewed
Jan 20, 2022
- created GeometryOperators\is_collinear
…o Enhancement/meandered_ports # Conflicts: # pyaedt/hfss.py
Alberto-DM
approved these changes
Jan 20, 2022
MaxJPRey
approved these changes
Jan 21, 2022
MaxJPRey
reviewed
Jan 21, 2022
MaxJPRey
reviewed
Jan 21, 2022
MaxJPRey
reviewed
Jan 21, 2022
| if bb_ratio > 2: | ||
| spiral_width = min(bb_dim) / 12 | ||
| filling = -0.2828*bb_ratio**2 + 3.4141*bb_ratio - 4.197 | ||
| print(filling) |
There was a problem hiding this comment.
Suggested change
| print(filling) |
Co-authored-by: Maxime Rey <[email protected]>
Co-authored-by: Maxime Rey <[email protected]>
Co-authored-by: Maxime Rey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user can now create a spiral inscribed inside a face and, from that one, create a complex 3d port that cover the full surface of the object. Useful when distributed port has to be created