Skip to content

Primitive functions #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jan 19, 2022
Merged

Primitive functions #739

merged 30 commits into from
Jan 19, 2022

Conversation

hui-zhou-a
Copy link
Contributor

No description provided.

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. Maybe I would only change the method name

@@ -536,6 +536,43 @@ def create_polygon(self, main_shape, layer_name, voids=[], net_name=""):
self._primitives_by_layer[layer_name] = [polygon]
return polygon

@aedt_exception_handler
def get_primitive(self, net_name=None, layer_name=None, prim_type=None, is_void=False):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can rename the method get_primitives since it is returning a list of primitives.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hui-zhou-a hui-zhou-a merged commit e422836 into main Jan 19, 2022
@hui-zhou-a hui-zhou-a deleted the primitive_functions branch January 19, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants