Fix/issue 659 #675
Merged
Fix/issue 659 #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxJPRey
force-pushed
the
fix/issue_659
branch
from
7d491ac to
254ae51
Compare
MaxJPRey
commented
Dec 24, 2021
| @@ -20,7 +22,7 @@ | |||
|
|
|||
| sys.path.append(os.path.join(root_path)) | |||
| project = "PyAEDT" | |||
| copyright = "(c) 2021 ANSYS, Inc. All rights reserved" | |||
| copyright = f"(c) {datetime.datetime.now().year} ANSYS, Inc. All rights reserved" | |||
| author = "Ansys Inc." | |||
|
|
|||
| # Check for the local config file, otherwise use default desktop configuration | |||
There was a problem hiding this comment.
@akaszynski In this file, few lines below, to get the semantic version, we are doing:
with open(os.path.join(root_path, "pyaedt", "version.txt"), "r") as f:
release = version = f.readline()
Do you think that we should expose the version in the _version.py with an attribute like this __version__ and then do in the conf.py file:
release = version = __version__
If yes, I will open an issue and commit this change in a separate pull request.
There was a problem hiding this comment.
Both approaches work. Since we already need to import pyaedt for the auto documentation to be built, I think it’s easier to:
from pyaedt import __version__
akaszynski
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #659 .
Logo is now provided through the pyansys_sphinx_theme.
In addition, the templates are no longer required.
Notify that PyAEDT is part of the larger PyANSYS effort in the README.rst file.