Rename argument 'major_raidus' as 'major_radius'. #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxJPRey
commented
Dec 20, 2021
| @@ -562,7 +562,7 @@ def create_circle(self, cs_plane, position, radius, numSides=0, is_covered=True, | |||
| return self._create_object(new_object_name) | |||
|
|
|||
| @aedt_exception_handler | |||
| def create_ellipse(self, cs_plane, position, major_raidus, ratio, is_covered=True, name=None, matname=None): | |||
| def create_ellipse(self, cs_plane, position, major_radius, ratio, is_covered=True, name=None, matname=None): | |||
There was a problem hiding this comment.
@maxcapodi78 I don't know if we should add a deprecation warning as it is an argument name and not the method name that was changed. Let say that one customer uses named arguments in his script with something like:
create_ellipse(, "XY", [0., 0.,0.], major_raidus = 3.2, ratio = 0.8, is_covered=True, name=None, matname=None)
Then his script will fail.
What do you think?
There was a problem hiding this comment.
it's a clear spelling error. I don't think it's needed deprecation warning as soon as it's documented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #662 .
Rename argument 'major_raidus' as 'major_radius' in the method create_ellipse() in the Primitives3D module.