Skip to content

Fix/issue 663 #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 21, 2021
Merged

Fix/issue 663 #665

merged 11 commits into from
Dec 21, 2021

Conversation

MaxJPRey
Copy link
Collaborator

Fix issue #663 . Fix the example provided in the toolkit module.
Improve some comments .

@MaxJPRey MaxJPRey requested a review from maxcapodi78 December 20, 2021 14:05
maxcapodi78
maxcapodi78 approved these changes Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxJPRey MaxJPRey linked an issue Dec 21, 2021 that may be closed by this pull request
Combox in the toolkit contains the same value twice #663
Closed
@MaxJPRey MaxJPRey merged commit a90fd52 into main Dec 21, 2021
@MaxJPRey MaxJPRey deleted the fix/issue_663 branch December 21, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcapodi78 maxcapodi78 maxcapodi78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combox in the toolkit contains the same value twice
2 participants
@MaxJPRey @maxcapodi78