Create port on component #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxJPRey
reviewed
Dec 16, 2021
Co-authored-by: Maxime Rey <[email protected]>
MaxJPRey
reviewed
Dec 17, 2021
MaxJPRey
reviewed
Dec 17, 2021
maxcapodi78
approved these changes
Dec 21, 2021
Comment on lines
+1183
to
+1190
| # pins = [] | ||
| # cmp_obj = list(cmp.LayoutObjs) | ||
| # for p in cmp_obj: | ||
| # if p.GetObjType() == 1: | ||
| # if p.IsLayoutPin(): | ||
| # pin_net_name = p.GetNet().GetName() | ||
| # if pin_net_name in netName: | ||
| # pins.append(p) |
There was a problem hiding this comment.
Suggested change
| # pins = [] | |
| # cmp_obj = list(cmp.LayoutObjs) | |
| # for p in cmp_obj: | |
| # if p.GetObjType() == 1: | |
| # if p.IsLayoutPin(): | |
| # pin_net_name = p.GetNet().GetName() | |
| # if pin_net_name in netName: | |
| # pins.append(p) |
Comment on lines
+651
to
+664
| """Test the component placment layer. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| cmp : self._edb.Cell.Hierarchy.Component | ||
| Edb component. | ||
|
|
||
| Returns | ||
| ------- | ||
| bool | ||
| ``True`` when component placed on top layer, ``False`` on bottom layer. | ||
|
|
||
|
|
||
| """ |
There was a problem hiding this comment.
Suggested change
| """Test the component placment layer. | |
| Parameters | |
| ---------- | |
| cmp : self._edb.Cell.Hierarchy.Component | |
| Edb component. | |
| Returns | |
| ------- | |
| bool | |
| ``True`` when component placed on top layer, ``False`` on bottom layer. | |
| """ |
Comment on lines
+569
to
+580
| """Creates edb pin group terminal from given edb pin group. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| pingroup : Edb pin group. | ||
|
|
||
| isref : bool | ||
|
|
||
| Returns | ||
| ------- | ||
| Edb pin group terminal. | ||
| """ |
There was a problem hiding this comment.
Suggested change
| """Creates edb pin group terminal from given edb pin group. | |
| Parameters | |
| ---------- | |
| pingroup : Edb pin group. | |
| isref : bool | |
| Returns | |
| ------- | |
| Edb pin group terminal. | |
| """ |
Comment on lines
+538
to
+550
| """Returns the closest pin from given pin among the list of reference pins. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| pin : Edb padstack instance. | ||
|
|
||
| ref_pinlist : list of reference edb pins. | ||
|
|
||
| Returns | ||
| ------- | ||
| Edb pin. | ||
|
|
||
| """ |
There was a problem hiding this comment.
Suggested change
| """Returns the closest pin from given pin among the list of reference pins. | |
| Parameters | |
| ---------- | |
| pin : Edb padstack instance. | |
| ref_pinlist : list of reference edb pins. | |
| Returns | |
| ------- | |
| Edb pin. | |
| """ |
MaxJPRey
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quite a big PR for creating ports on components.