Skip to content

Remove unused argument description. #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2021
Merged

Remove unused argument description. #644

merged 1 commit into from
Dec 14, 2021

Conversation

MaxJPRey
Copy link
Collaborator

Fix issue #643.

ypos is not an argument of the method create_resistor anymore.

@MaxJPRey MaxJPRey requested a review from maxcapodi78 December 14, 2021 10:37
@MaxJPRey MaxJPRey linked an issue Dec 14, 2021 that may be closed by this pull request
ypos argument of create_resistor() method in PrimitivesNexxim not used. #643
Closed
maxcapodi78
maxcapodi78 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxJPRey MaxJPRey merged commit 8ba3e00 into main Dec 14, 2021
@MaxJPRey MaxJPRey deleted the fix/issue_643 branch December 14, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcapodi78 maxcapodi78 maxcapodi78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ypos argument of create_resistor() method in PrimitivesNexxim not used.
2 participants
@MaxJPRey @maxcapodi78