Added First Implementation of BH Curves. At this time Temperature dep… #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endance is not implemented
|
@beliaev-maksim I've created a new branch and created a new PR |
beliaev-maksim
suggested changes
Dec 9, 2021
MaxJPRey
approved these changes
Dec 9, 2021
MaxJPRey
reviewed
Dec 9, 2021
MaxJPRey
reviewed
Dec 9, 2021
MaxJPRey
reviewed
Dec 9, 2021
| @@ -232,6 +232,12 @@ def __init__(self, material, name, val=None, thermalmodifier=None): | |||
| elif val is not None and val["property_type"] == "AnisoProperty": | |||
| self.type = "anisotropic" | |||
| self.value = [val["component1"], val["component2"], val["component3"]] | |||
| elif val is not None and val["property_type"] == "nonlinear": | |||
There was a problem hiding this comment.
Suggested change
| elif val is not None and val["property_type"] == "nonlinear": | |
| elif val["property_type"] == "nonlinear": |
There was a problem hiding this comment.
@MaxJPRey I cannot commit this modification. If val is None then it would fail in looking for "property_type". So I need first to check that val is filled and then search for the type
There was a problem hiding this comment.
Yes you are write, it would require a try/except block to prevent from that and raise an exception.
There was a problem hiding this comment.
try/except is more expensive when it raises compared to type check
|
Approved with suggestion.. |
Co-authored-by: Maksim Beliaev <[email protected]> Co-authored-by: Maxime Rey <[email protected]>
Co-authored-by: Maxime Rey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…endance is not implemented