Skip to content

FEAT: New version of point_in_polygon for higher performances #6283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 19, 2025

Conversation

Alberto-DM
Copy link
Contributor

@Alberto-DM Alberto-DM commented Jun 18, 2025

Description

GeometryOperators.point_in_polygon method has been improved.
All function calls has been removed and substituted with optimized equations.
We have 4X speed improvement in debug and 3X speed improvement in run.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.20%. Comparing base (835760e) to head (b527ae4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6283      +/-   ##
==========================================
- Coverage   85.21%   85.20%   -0.02%     
==========================================
  Files         172      172              
  Lines       65044    65047       +3     
==========================================
- Hits        55428    55421       -7     
- Misses       9616     9626      +10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alberto-DM Alberto-DM marked this pull request as ready for review June 19, 2025 10:37
@Alberto-DM Alberto-DM requested a review from a team as a code owner June 19, 2025 10:37
@Alberto-DM Alberto-DM enabled auto-merge (squash) June 19, 2025 10:38
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alberto-DM Alberto-DM merged commit c83395d into main Jun 19, 2025
38 of 59 checks passed
@Alberto-DM Alberto-DM deleted the improve-points-in-polygon branch June 19, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants