Skip to content

FEAT: Coordinate system in HFSS 3D Layout #6255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 13, 2025
Merged

Conversation

Samuelopez-ansys
Copy link
Member

Description

Add HFSS 3D Layout Coordinate system class.

Issue linked

Close #6254

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Samuelopez-ansys Samuelopez-ansys requested a review from a team as a code owner June 11, 2025 12:10
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys Samuelopez-ansys requested review from hui-zhou-a and removed request for a team June 11, 2025 12:11
@github-actions github-actions bot added the enhancement New features or code improvements label Jun 11, 2025
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 97.02970% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (4ff3264) to head (b46e997).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6255      +/-   ##
==========================================
+ Coverage   85.24%   85.26%   +0.01%     
==========================================
  Files         170      170              
  Lines       64463    64564     +101     
==========================================
+ Hits        54952    55051      +99     
- Misses       9511     9513       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

maxcapodi78
maxcapodi78 previously approved these changes Jun 11, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some minor comments.

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) June 12, 2025 15:37
@Samuelopez-ansys Samuelopez-ansys merged commit 12fdca4 into main Jun 13, 2025
37 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/issue_6254 branch June 13, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinate system in HFSS 3D Layout
4 participants