Skip to content

FIX: Import graphic dependencies if needed #6246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 10, 2025

Conversation

Samuelopez-ansys
Copy link
Member

Description

Import graphic dependencies if needed.
Fix Q3D regression in 2025R2

Issue linked

Close #6241

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Samuelopez-ansys Samuelopez-ansys requested a review from a team as a code owner June 9, 2025 13:49
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Jun 9, 2025
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.21%. Comparing base (91adc3b) to head (9580548).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (82.85%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6246      +/-   ##
==========================================
- Coverage   85.22%   85.21%   -0.02%     
==========================================
  Files         170      170              
  Lines       64329    64356      +27     
==========================================
+ Hits        54826    54842      +16     
- Misses       9503     9514      +11     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SMoraisAnsys
SMoraisAnsys previously approved these changes Jun 10, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Sébastien Morais <[email protected]>
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) June 10, 2025 09:02
@Samuelopez-ansys Samuelopez-ansys merged commit dfb7c1b into main Jun 10, 2025
36 of 37 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/q3d_2025r2_regression branch June 10, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export_field_file throws ERROR_GRAPHICS_REQUIRED warnings
3 participants