-
Notifications
You must be signed in to change notification settings - Fork 161
REFACTOR: Extension architecture using common class #6238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6238 +/- ##
==========================================
+ Coverage 85.22% 85.23% +0.01%
==========================================
Files 170 170
Lines 64364 64463 +99
==========================================
+ Hits 54855 54946 +91
- Misses 9509 9517 +8 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I like it a lot!
Great code @SMoraisAnsys . |
SUPER! |
Co-authored-by: Maxime Rey <[email protected]>
…aedt into refactor/extension-architecture
…aedt into refactor/extension-architecture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Description
This PR aims at refactoring the extension by providing a common class. This class encapsulate a few common behavior of the current extensions and it is used + tested to created the template extension.
Issue linked
Associated to #6228
Checklist