Skip to content

REFACTOR: Import nastran extension and tests #6227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 5, 2025

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Jun 4, 2025

Description

Refactoring of the import nastran extension where the extension has been updated to allow testing with tkinter direct interaction.

Issue linked

Associated to #6228

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner June 4, 2025 08:48
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys self-assigned this Jun 4, 2025
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of using os.path, we could use pathlib?

@SMoraisAnsys
Copy link
Collaborator Author

Maybe instead of using os.path, we could use pathlib?

Sure

@github-actions github-actions bot added the maintenance Package and maintenance related label Jun 4, 2025
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.20%. Comparing base (5bc3a10) to head (927109d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6227      +/-   ##
==========================================
- Coverage   85.20%   85.20%   -0.01%     
==========================================
  Files         170      170              
  Lines       64209    64332     +123     
==========================================
+ Hits        54711    54815     +104     
- Misses       9498     9517      +19     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys
Copy link
Member

@SMoraisAnsys Great job! I like it a lot, should we also test

root.nametowidget("preview_button").invoke()?

Or the toogle theme? Maybe we could add another test for this common funcionalities?

I was thinking that maybe in a next PR, we could create a class to define the default UI, because then maybe we can start creating method to building common stuff like multitabs, buttons... following the same structure, what do you think?

@SMoraisAnsys
Copy link
Collaborator Author

@SMoraisAnsys Great job! I like it a lot, should we also test

root.nametowidget("preview_button").invoke()?

Or the toogle theme? Maybe we could add another test for this common funcionalities?

I was thinking that maybe in a next PR, we could create a class to define the default UI, because then maybe we can start creating method to building common stuff like multitabs, buttons... following the same structure, what do you think?

Maybe I'm missing something but the preview button and toggle button are tested in https://github.com/ansys/pyaedt/pull/6227/files#diff-ac52ccb11fa1ba48938746d6dbe8a83b26b7d455bb64077eee93ad579dd83161
Do you have something else in mind ?

I do agree with a follow-up PR where we create a defaut UI class. I'll handle it if that's ok with you

@SMoraisAnsys SMoraisAnsys merged commit 18f9830 into main Jun 5, 2025
62 of 64 checks passed
@SMoraisAnsys SMoraisAnsys deleted the refactor/extension-implementation-and-testing branch June 5, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants