Skip to content

FIX: Improve the speed up of the cleanup of objects and delete of objects in modeler. #6170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 21, 2025

Conversation

maxcapodi78
Copy link
Collaborator

Improve the speed up of the cleanup of objects and delete of objects in modeler.
This is particularly useful on big models

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

…in modeler. This is particularly useful on big models
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label May 19, 2025
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.25%. Comparing base (1ee0131) to head (4c2eba9).
Report is 4 commits behind head on main.

❌ Your patch status has failed because the patch coverage (76.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6170      +/-   ##
==========================================
- Coverage   85.25%   85.25%   -0.01%     
==========================================
  Files         170      170              
  Lines       64095    64107      +12     
==========================================
+ Hits        54647    54655       +8     
- Misses       9448     9452       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maxcapodi78 maxcapodi78 requested a review from a team as a code owner May 19, 2025 14:12
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be more efficient

@maxcapodi78 maxcapodi78 enabled auto-merge (squash) May 21, 2025 11:16
@maxcapodi78 maxcapodi78 merged commit 18d06d8 into main May 21, 2025
33 of 34 checks passed
@maxcapodi78 maxcapodi78 deleted the fix_improve_speedup_delete_method branch May 21, 2025 11:33
jsalant22 pushed a commit that referenced this pull request Jun 3, 2025
…ects in modeler. (#6170)

Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Samuel Lopez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants