Skip to content

FIX: ISAR 2D range extents #6162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 16, 2025
Merged

FIX: ISAR 2D range extents #6162

merged 20 commits into from
May 16, 2025

Conversation

scanta2
Copy link
Contributor

@scanta2 scanta2 commented May 15, 2025

Description

ISAR 2D calculations were not coded correctly.
Add a pcolor-like capability to pyaedt. Switch some hardwired values to SpeedOfLight.

Issue linked

Corrects ISAR 2D calculations for ISAR images on the xy plane.
Adds pcolor plots to pyaedt for, e.g., rendering ISAR 2D images.

Checklist

  • [ v] I have tested my changes locally.
  • [v ] I have added necessary documentation or updated existing documentation.
  • [ v] I have followed the coding style guidelines of this project.
  • [v ] I have added appropriate tests (unit, integration, system).
  • [ v] I have reviewed my changes before submitting this pull request.
  • [v ] I have linked the issue or issues that are solved by the PR if any.
  • [v ] I have agreed with the Contributor License Agreement (CLA).

@scanta2 scanta2 requested a review from Samuelopez-ansys May 15, 2025 18:48
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@scanta2 scanta2 changed the title 47 fix range extends FIX: 47 fix range extends May 15, 2025
@scanta2 scanta2 changed the title FIX: 47 fix range extends FIX: ISAR 2D range extents May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 97.56098% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.20%. Comparing base (2eeae49) to head (c2caae6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6162      +/-   ##
==========================================
+ Coverage   85.18%   85.20%   +0.02%     
==========================================
  Files         169      169              
  Lines       63991    64033      +42     
==========================================
+ Hits        54513    54562      +49     
+ Misses       9478     9471       -7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Samuelopez-ansys Samuelopez-ansys merged commit 07edcc1 into main May 16, 2025
34 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the 47_fix_range_extends branch May 16, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants