Fix/issue 609 #616
Merged
Fix/issue 609 #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxJPRey
commented
Dec 2, 2021
| units = _find_units_in_dependent_variables(variable_value, full_variables) | ||
|
|
||
| if loc: | ||
| loc_units = loc.span()[0] | ||
| extract_units = variable_value[loc_units:] | ||
| if unit_system(extract_units): |
There was a problem hiding this comment.
@maxcapodi78 This unit_system() method is using the dictionary AEDT_UNITS. This dictionary does not contain units such as area m², volume m^3. Consequently it was not working for "3.123456m2" as described in issue #609.
There was a problem hiding this comment.
got it. Do you think we should add it or your fix handles all conditions?
maxcapodi78
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #609 .
The variable decomposition was not working for units including both letters and digits such as 'm2'.
With the new modification we get the index of the first letter in the
variablestring and then we split it to get the unit and the value.