-
Notifications
You must be signed in to change notification settings - Fork 161
FIX: Correct unit for h-field in set_non_linear() for bh curve definition #6156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I fixed a bug last week because they were changed, but I introduced another bug.
Please could you add a test to avoid this? Maybe you can add something similar to what it triggered you to find the bug
@Samuelopez-ansys |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6156 +/- ##
=======================================
Coverage 85.22% 85.22%
=======================================
Files 167 167
Lines 63737 63737
=======================================
Hits 54323 54323
Misses 9414 9414 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Issue linked
#6154