Skip to content

FIX: Add mesh link wrong source design solution selection #6133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 10, 2025

Conversation

gmalinve
Copy link
Contributor

@gmalinve gmalinve commented May 8, 2025

Description

Wrong source design solution selection

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@gmalinve gmalinve self-assigned this May 8, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve marked this pull request as draft May 8, 2025 16:59
@github-actions github-actions bot added the bug Something isn't working label May 8, 2025
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (7246ecf) to head (df757c4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6133      +/-   ##
==========================================
+ Coverage   83.96%   85.23%   +1.27%     
==========================================
  Files         167      167              
  Lines       63635    63637       +2     
==========================================
+ Hits        53428    54240     +812     
+ Misses      10207     9397     -810     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gmalinve gmalinve marked this pull request as ready for review May 9, 2025 08:54
@gmalinve gmalinve linked an issue May 9, 2025 that may be closed by this pull request
2 tasks
anur7
anur7 previously approved these changes May 9, 2025
Copy link
Contributor

@anur7 anur7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and it works. Great job @gmalinve

MaxJPRey
MaxJPRey previously approved these changes May 9, 2025
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmalinve gmalinve dismissed stale reviews from MaxJPRey and anur7 via 9969d43 May 9, 2025 14:26
@Samuelopez-ansys Samuelopez-ansys changed the title FIX: add mesh link FIX: Add mesh link wrong source design solution selection May 9, 2025
@gmalinve gmalinve merged commit 30d459d into main May 10, 2025
33 checks passed
@gmalinve gmalinve deleted the fix/add_mesh_link branch May 10, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in Setup add_mesh_link
5 participants