-
Notifications
You must be signed in to change notification settings - Fork 161
FIX: External circuit import of renamed sources #6128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6128 +/- ##
==========================================
+ Coverage 85.14% 85.16% +0.01%
==========================================
Files 167 167
Lines 63596 63602 +6
==========================================
+ Hits 54148 54164 +16
+ Misses 9448 9438 -10 🚀 New features to boost your workflow:
|
# Conflicts: # src/ansys/aedt/core/maxwell.py
Co-authored-by: Samuel Lopez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @vpipidis ! Your first PR, Congrats
Description
Created a check whether the source has a custom name before evaluating the label to pass as an argument on Maxwell3D.edit_external_circuit
Issue linked
#6127
Checklist