Skip to content

FEAT: Added support for pass_fail criteria into the main.json #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025

Conversation

maxcapodi78
Copy link
Collaborator

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@maxcapodi78 maxcapodi78 enabled auto-merge (squash) May 7, 2025 14:30
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 78.72340% with 20 lines in your changes missing coverage. Please review.

Project coverage is 85.16%. Comparing base (4098cf4) to head (639d3bb).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (78.72%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6124      +/-   ##
==========================================
- Coverage   85.30%   85.16%   -0.15%     
==========================================
  Files         167      167              
  Lines       63528    63594      +66     
==========================================
- Hits        54194    54160      -34     
- Misses       9334     9434     +100     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maxcapodi78 maxcapodi78 merged commit aa5a0f7 into main May 7, 2025
31 of 32 checks passed
@maxcapodi78 maxcapodi78 deleted the add_pass_fail_criteria_to_main branch May 7, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants