-
Notifications
You must be signed in to change notification settings - Fork 162
REFACTOR: Extension manager compatible with toolkits #6115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6115 +/- ##
==========================================
+ Coverage 85.20% 85.22% +0.01%
==========================================
Files 169 169
Lines 64033 64036 +3
==========================================
+ Hits 54559 54572 +13
+ Misses 9474 9464 -10 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't finished to review but the changes seem great. I'll take more time later
Co-authored-by: Sébastien Morais <[email protected]>
…o refactor/installer_toolkits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
Toolkits are going to be installed as a program. This refactoring is to allow easy installation of toolkits (Antenna and magnet toolkit)
Issue linked
Close #6113
Close #6036
Checklist