Skip to content

REFACTOR: Extension manager compatible with toolkits #6115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
May 16, 2025

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented May 6, 2025

Description

Toolkits are going to be installed as a program. This refactoring is to allow easy installation of toolkits (Antenna and magnet toolkit)

Issue linked

Close #6113
Close #6036

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (07edcc1) to head (69e08db).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6115      +/-   ##
==========================================
+ Coverage   85.20%   85.22%   +0.01%     
==========================================
  Files         169      169              
  Lines       64033    64036       +3     
==========================================
+ Hits        54559    54572      +13     
+ Misses       9474     9464      -10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't finished to review but the changes seem great. I'll take more time later

hui-zhou-a
hui-zhou-a previously approved these changes May 13, 2025
Copy link
Contributor

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) May 16, 2025 09:33
@Samuelopez-ansys Samuelopez-ansys merged commit 48e53a3 into main May 16, 2025
34 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refactor/installer_toolkits branch May 16, 2025 09:52
@gmalinve gmalinve linked an issue May 17, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
5 participants