-
Notifications
You must be signed in to change notification settings - Fork 161
CI: Add vulnerability checking #6112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6112 +/- ##
==========================================
+ Coverage 85.66% 85.73% +0.07%
==========================================
Files 166 167 +1
Lines 62786 63348 +562
==========================================
+ Hits 53783 54312 +529
- Misses 9003 9036 +33 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
After multiple PRs, the repo is in a state where it is compatible with our vulnerability action. For information on how to handle multiple situations like a vulnerability source, discovery, tracking, remediation, ... have a look at our dev guide documentation.
Warning
We can configure
Bandit
to ignore specific advisories (for example, using# nosec
). This can be due to the code not being ready yet to be fixed or that the advisory is not relevant to the codebase. However, it is important to note that ignoring advisories should be done with caution, and we should be aware of the potential risks involved. Also, we should document the reasons for ignoring advisories and ensure that they are regularly reviewed to determine if they can be addressed. This is already a WIP, see https://aedt.docs.pyansys.com/version/stable/User_guide/security_consideration.htmlIssue linked
Related to #5524 #5504
Checklist