-
Notifications
You must be signed in to change notification settings - Fork 161
FEAT: Added automatic search in modeler getitem of FaceID and Edge Ids. #6109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
self.aedtapp.modeler[xx] will return the FacePrimitive or EdgePrimitive depending to which the id it belongs
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (80.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6109 +/- ##
==========================================
- Coverage 85.74% 85.74% -0.01%
==========================================
Files 167 167
Lines 63348 63367 +19
==========================================
+ Hits 54318 54332 +14
- Misses 9030 9035 +5 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…prove_modeler_getitem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
self.aedtapp.modeler[xx] will return the FacePrimitive or EdgePrimitive depending to which the id it belongs
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist