Skip to content

FIX: Return None in compute power loss if no solution available #6106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2025

Conversation

hui-zhou-a
Copy link
Contributor

@hui-zhou-a hui-zhou-a commented May 5, 2025

Exit the method if solution doesn't exist.

Close #6107

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label May 5, 2025
@hui-zhou-a hui-zhou-a linked an issue May 5, 2025 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.26%. Comparing base (9015401) to head (7191f37).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6106      +/-   ##
==========================================
+ Coverage   85.25%   85.26%   +0.01%     
==========================================
  Files         170      170              
  Lines       64100    64100              
==========================================
+ Hits        54646    54653       +7     
+ Misses       9454     9447       -7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys changed the title FIX: Compute power loss FIX: Return None in compute power loss if no solution available May 20, 2025
@Samuelopez-ansys Samuelopez-ansys requested a review from a team as a code owner May 20, 2025 13:40
@Samuelopez-ansys Samuelopez-ansys merged commit d97a29e into main May 20, 2025
33 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix-compute_power branch May 20, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to compute power loss if solution doesn't exist
4 participants