Skip to content

REFACTOR: Refactor/12 post processing test #6095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 14, 2025

Conversation

nunesanderson
Copy link
Contributor

@nunesanderson nunesanderson commented Apr 30, 2025

Description

Post-processing test refactor

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@nunesanderson nunesanderson requested a review from gmalinve April 30, 2025 08:51
@nunesanderson nunesanderson self-assigned this Apr 30, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@nunesanderson nunesanderson linked an issue Apr 30, 2025 that may be closed by this pull request
@nunesanderson nunesanderson added maintenance Package and maintenance related documentation Improvements or additions to documentation labels Apr 30, 2025
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.20%. Comparing base (5addaec) to head (472f3be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6095      +/-   ##
==========================================
- Coverage   85.24%   85.20%   -0.05%     
==========================================
  Files         167      167              
  Lines       63657    63661       +4     
==========================================
- Hits        54265    54242      -23     
- Misses       9392     9419      +27     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gmalinve gmalinve marked this pull request as ready for review May 9, 2025 09:05
gmalinve
gmalinve previously approved these changes May 9, 2025
Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very nice job, thank you!!

Removed not used comment

Co-authored-by: Sébastien Morais <[email protected]>
Removed unused comment.

Co-authored-by: Sébastien Morais <[email protected]>
Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@nunesanderson nunesanderson merged commit 1d493d7 into main May 14, 2025
34 checks passed
@nunesanderson nunesanderson deleted the refactor/12_post_processing_test branch May 14, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

12_post_processing file refactoring
4 participants