Skip to content

FIX: Schematic name argument optional in edit_external_circuit method #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2025

Conversation

gmalinve
Copy link
Contributor

@gmalinve gmalinve commented Apr 29, 2025

Description

In this PR I made the schematic name as an optional argument because is not always needed to be provided.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@gmalinve gmalinve self-assigned this Apr 29, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Apr 29, 2025
@Samuelopez-ansys
Copy link
Member

@gmalinve Could you modify the title of the PR to improve the readability of the changelog?

@gmalinve gmalinve marked this pull request as draft April 29, 2025 13:18
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.16%. Comparing base (eb757a3) to head (7f11ced).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6092      +/-   ##
==========================================
- Coverage   85.16%   85.16%   -0.01%     
==========================================
  Files         167      167              
  Lines       63153    63146       -7     
==========================================
- Hits        53785    53779       -6     
+ Misses       9368     9367       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gmalinve gmalinve marked this pull request as ready for review April 29, 2025 13:27
@gmalinve gmalinve changed the title FIX: edit_external_circuit FIX: edit_external_circuit optional schematic name arg Apr 29, 2025
@Samuelopez-ansys Samuelopez-ansys changed the title FIX: edit_external_circuit optional schematic name arg FIX: Schematic name argument optional in edit_external_circuit method Apr 29, 2025
@Samuelopez-ansys Samuelopez-ansys merged commit ab4ce91 into main Apr 30, 2025
30 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/edit_external_circuit branch April 30, 2025 14:18
@IreneWoyna-HE
Copy link

IreneWoyna-HE commented May 6, 2025

@gmalinve @Samuelopez-ansys you are the best!! ❤️

But unfortunately there's still an issue, I guess the function should read the sources_array from the netlist, now it attempts to read it from the non-existing circuit:

[error] m2d.edit_external_circuit(netlist_file_path=netlist_file)
[error] Cannot access local variable 'sources_array' where it is not associated with a value on edit_external_circuit
[error] Last Electronics Desktop Message - [error] cannot access local variable 'sources_array' where it is not associated with a value on edit_external_circuit
[error] Method arguments:
[error] netlist_file_path = C:/.../netlist1.sph
[error] **************************************************************

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

edit_external_circuit() requires schematic_design_name as an input without any reason
4 participants