-
Notifications
You must be signed in to change notification settings - Fork 161
FIX: Schematic name argument optional in edit_external_circuit method #6092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
@gmalinve Could you modify the title of the PR to improve the readability of the changelog? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6092 +/- ##
==========================================
- Coverage 85.16% 85.16% -0.01%
==========================================
Files 167 167
Lines 63153 63146 -7
==========================================
- Hits 53785 53779 -6
+ Misses 9368 9367 -1 🚀 New features to boost your workflow:
|
@gmalinve @Samuelopez-ansys you are the best!! ❤️ But unfortunately there's still an issue, I guess the function should read the sources_array from the netlist, now it attempts to read it from the non-existing circuit: [error] m2d.edit_external_circuit(netlist_file_path=netlist_file) |
Description
In this PR I made the schematic name as an optional argument because is not always needed to be provided.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist